Message350411
> Is there a particular reason to specifically call PyLong_FromSize_t? Seems like PyLong_FromLong is the natural default (and what we default to in the rest of the code), and it's what this ends up calling anyway.
Ah I see, the patch is meant to go on top of GH-15192, which makes PyLong_FromSize_t apply the small-int optimization itself.
As I just suggested on GH-15192, I'd like to see that PR apply the small-int optimization in the more broadly-used PyLong_FromUnsignedLong... and then I think the natural thing for this new function to do is to call that.
Still quite curious how LTO does, and also curious what compiler and flags you're using in benchmarks. |
|
Date |
User |
Action |
Args |
2019-08-24 23:22:38 | Greg Price | set | recipients:
+ Greg Price, jdemeyer, sir-sigurd |
2019-08-24 23:22:38 | Greg Price | set | messageid: <1566688958.43.0.896087473315.issue37837@roundup.psfhosted.org> |
2019-08-24 23:22:38 | Greg Price | link | issue37837 messages |
2019-08-24 23:22:38 | Greg Price | create | |
|