Author rhettinger
Recipients Greg Price, Ma Lin, aeros, mark.dickinson, rhettinger, sir-sigurd
Date 2019-08-24.17:03:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1566666207.02.0.399952171238.issue37812@roundup.psfhosted.org>
In-reply-to
Content
> I noticed a very similar story in CHECK_BINOP.

How about we don't do any more of these :-)

I understand the desire to have an explicit return but don't think these minor aesthetics are worth it.  The existing code was correct. The patches increase the total code volume.  There are subtle differences during the transformation (macros don't require type declarations). They are a bit tedious to review and are eating up our time in the back and forth. All changes like this risk introducing bugs into otherwise correct code.  Minor code churn is rarely worth it.

May I suggest directing your efforts towards fixing known bugs or implementing requested features.  It isn't our goal to create more work for one another ;-)
History
Date User Action Args
2019-08-24 17:03:27rhettingersetrecipients: + rhettinger, mark.dickinson, Ma Lin, Greg Price, sir-sigurd, aeros
2019-08-24 17:03:27rhettingersetmessageid: <1566666207.02.0.399952171238.issue37812@roundup.psfhosted.org>
2019-08-24 17:03:27rhettingerlinkissue37812 messages
2019-08-24 17:03:26rhettingercreate