Author rhettinger
Recipients Mark.Shannon, eric.snow, mpaolini, python-dev, rhettinger, serhiy.storchaka, terry.reedy
Date 2019-08-22.23:07:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1566515265.01.0.10524742458.issue24726@roundup.psfhosted.org>
In-reply-to
Content
There may still be some holes still remaining in OrderedDict but it doesn't seem to have been relevant in practice and will become even less so now that regular dicts are ordered and compact.  

If an issue does are arise with someone setting OrderedDict values via dict.__setitem__ we should probably just document "don't do that" rather than performing brain surgery on the current implementation which was known in advance to be vulnerable to exactly this sort of trickery.

If there are no objections, I recommend closing this as out-of-date.   IMO this would be better than risking introducing new problems are getting the C version further out of sync with the Python version or altering how existing code is working.
History
Date User Action Args
2019-08-22 23:07:45rhettingersetrecipients: + rhettinger, terry.reedy, Mark.Shannon, python-dev, eric.snow, serhiy.storchaka, mpaolini
2019-08-22 23:07:45rhettingersetmessageid: <1566515265.01.0.10524742458.issue24726@roundup.psfhosted.org>
2019-08-22 23:07:44rhettingerlinkissue24726 messages
2019-08-22 23:07:44rhettingercreate