Author steve.dower
Recipients Christian Åkerström, Ethan Smith, eric.smith, eryksun, ishimoto, jaraco, living180, miss-islington, ncdave4life, pablogsal, paul.moore, pitrou, steve.dower, stutzbach, takluyver, tim.golden, zach.ware, Étienne Dupuis
Date 2019-08-21.21:56:48
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1566424608.7.0.448577705156.issue9949@roundup.psfhosted.org>
In-reply-to
Content
I suspect the relevant failure here (which is not listed in Pablo's post) is this one:

======================================================================
ERROR: test_realpath_curdir (test.test_ntpath.TestNtpath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_ntpath.py", line 210, in test_realpath_curdir
    tester("ntpath.realpath('/'.join(['.'] * 100))", expected)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_ntpath.py", line 30, in tester
    raise TestFailed("%s should return: %s but returned: %s" \
test.support.TestFailed: ntpath.realpath('/'.join(['.'] * 100)) should return: C:\buildbot.python.org\3.x.kloth-win64\build\build\test_python_5340\test_python_worker_1408 but returned: \\?\C:\buildbot.python.org\3.x.kloth-win64\build\build\test_python_5340\test_python_worker_1408\.\.\.\.\.\.\.\.\.\.\.\.\.\.\.\.

The path being normalized is longer than MAX_PATH, which is clearly causing failures with Windows APIs as implemented on Windows 7.

I can add the normpath() call back in, which should remove all the dots before ever actually testing realpath() and get it back down under MAX_PATH. That won't help anyone using real long paths on Win7 though, but then again the only reason this test was passing before was because there was a normpath() call, so we're no worse off (apart from performance-wise).

The venv issues seem unrelated. I'll get the realpath one fixed first and then take a look at those once I've finished today's tasks.
History
Date User Action Args
2019-08-21 21:56:48steve.dowersetrecipients: + steve.dower, paul.moore, ishimoto, jaraco, pitrou, eric.smith, tim.golden, stutzbach, living180, takluyver, zach.ware, ncdave4life, eryksun, Christian Åkerström, Ethan Smith, pablogsal, Étienne Dupuis, miss-islington
2019-08-21 21:56:48steve.dowersetmessageid: <1566424608.7.0.448577705156.issue9949@roundup.psfhosted.org>
2019-08-21 21:56:48steve.dowerlinkissue9949 messages
2019-08-21 21:56:48steve.dowercreate