This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients jdemeyer, mark.dickinson, rhettinger, serhiy.storchaka, steven.daprano
Date 2019-08-20.14:11:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1566310317.05.0.297267092272.issue37884@roundup.psfhosted.org>
In-reply-to
Content
> This issue if for optimization only. It does not expand the math module API.

I think it does, though. The PR adds something to the math module that's tested, that needs to be maintained for other modules to work, and that's imported for use in another module; that smells like an element of the API to me, even with the leading underscore in the name. Other Python implementations would also need to implement math._as_integer_ratio for the pure Python fractions code to continue working. If we're going to expand the math module API to include such a function (and I don't think we should), we should do it properly: remove the leading underscore, and add documentation. But as you say, that's a separate issue.

I'm with Raymond here; I don't think this change is desirable for the math module, either with or without the leading underscore in the name.
History
Date User Action Args
2019-08-20 14:11:57mark.dickinsonsetrecipients: + mark.dickinson, rhettinger, steven.daprano, serhiy.storchaka, jdemeyer
2019-08-20 14:11:57mark.dickinsonsetmessageid: <1566310317.05.0.297267092272.issue37884@roundup.psfhosted.org>
2019-08-20 14:11:57mark.dickinsonlinkissue37884 messages
2019-08-20 14:11:56mark.dickinsoncreate