Message349992
Thank you for your patch hai shi. But note that assertion_error is a static variable. It is initialized only once. Your change makes it holding a borrowed reference after first call of compiler_assert(). This does not look reliable.
In any case assertion_error will gone after resolving issue34880, so I am closing this issue in favor of that.
If not issue34880, it would be better to use a private API for _Py_IDENTIFIER here. |
|
Date |
User |
Action |
Args |
2019-08-20 06:41:53 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, pitrou, vstinner, pablogsal, shihai1991 |
2019-08-20 06:41:53 | serhiy.storchaka | set | messageid: <1566283313.36.0.981532220109.issue37887@roundup.psfhosted.org> |
2019-08-20 06:41:53 | serhiy.storchaka | link | issue37887 messages |
2019-08-20 06:41:53 | serhiy.storchaka | create | |
|