This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients pablogsal, pitrou, serhiy.storchaka, shihai1991, vstinner
Date 2019-08-20.06:41:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1566283313.36.0.981532220109.issue37887@roundup.psfhosted.org>
In-reply-to
Content
Thank you for your patch hai shi. But note that assertion_error is a static variable. It is initialized only once. Your change makes it holding a borrowed reference after first call of compiler_assert(). This does not look reliable.

In any case assertion_error will gone after resolving issue34880, so I am closing this issue in favor of that.

If not issue34880, it would be better to use a private API for _Py_IDENTIFIER here.
History
Date User Action Args
2019-08-20 06:41:53serhiy.storchakasetrecipients: + serhiy.storchaka, pitrou, vstinner, pablogsal, shihai1991
2019-08-20 06:41:53serhiy.storchakasetmessageid: <1566283313.36.0.981532220109.issue37887@roundup.psfhosted.org>
2019-08-20 06:41:53serhiy.storchakalinkissue37887 messages
2019-08-20 06:41:53serhiy.storchakacreate