Author jdemeyer
Recipients Ma Lin, Mark.Shannon, inada.naoki, jdemeyer, josh.r, vstinner
Date 2019-08-13.13:00:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1565701214.39.0.242728515049.issue37774@roundup.psfhosted.org>
In-reply-to
Content
> If it's an optimization, can you show a benchmark to validate that it's really faster as expected?

Yes, I did test it. I didn't save the results, but I can redo them if you want. If you plan to reject the issue anyway, there is no point.

> not building with PGO lead to random performances

I would expect that Py_LIKELY/Py_UNLIKELY helps with this. If the compiler doesn't have probability information, it guesses. This can cause unrelated changes to change the heuristics used by the compiler, impacting the performance of some piece of code. With Py_LIKELY/Py_UNLIKELY, the code generated by the compiler should be more stable.
History
Date User Action Args
2019-08-13 13:00:14jdemeyersetrecipients: + jdemeyer, vstinner, inada.naoki, Mark.Shannon, josh.r, Ma Lin
2019-08-13 13:00:14jdemeyersetmessageid: <1565701214.39.0.242728515049.issue37774@roundup.psfhosted.org>
2019-08-13 13:00:14jdemeyerlinkissue37774 messages
2019-08-13 13:00:14jdemeyercreate