Author gvanrossum
Recipients barry, emilyemorehouse, eric.smith, gvanrossum, joernheissler, koobs, miss-islington, ncoghlan, nedbat, pablogsal, rhettinger, serhiy.storchaka, steven.daprano, tim.peters, veky, willingc, xtreak
Date 2019-08-05.04:15:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1564978506.75.0.3516829552.issue35224@roundup.psfhosted.org>
In-reply-to
Content
Thanks for catching that this was still incomplete.

> Also, a major procedural note: it is NOT OK to merge a PEP implementation that completely ignores parts of the PEP. The merged tests are actively forcing NON-compliance with the accepted PEP, since they're requiring implementations to accept code that the PEP explicitly states should be disallowed.

It was known the implementation was unfinished in this respect, but it was deemed better to merge what we had lest the work be lost in merge conflicts, and iterate in later betas. I've written some code that uses the walrus operator and have found it quite solid. The early existence of an implementation (albeit incomplete) has also helped get support for this in mypy (https://github.com/python/mypy/pull/6899).

I don't recall being aware that there were tests that specifically *checked* that the implementation was incomplete, and that's obviously wrong.
History
Date User Action Args
2019-08-05 04:15:06gvanrossumsetrecipients: + gvanrossum, tim.peters, barry, rhettinger, ncoghlan, eric.smith, nedbat, steven.daprano, serhiy.storchaka, koobs, willingc, veky, emilyemorehouse, joernheissler, pablogsal, miss-islington, xtreak
2019-08-05 04:15:06gvanrossumsetmessageid: <1564978506.75.0.3516829552.issue35224@roundup.psfhosted.org>
2019-08-05 04:15:06gvanrossumlinkissue35224 messages
2019-08-05 04:15:06gvanrossumcreate