Author steve.dower
Recipients christian.heimes, ezio.melotti, methane, miss-islington, mpaolini, ncoghlan, pablogsal, rhettinger, serhiy.storchaka, steve.dower
Date 2019-07-30.15:43:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1564501432.5.0.858745115243.issue37587@roundup.psfhosted.org>
In-reply-to
Content
> compiler stores the `c` to stack every time

The disassembly we looked at didn't do this, so it may just be certain compilers. Perhaps we can actually use the register keyword to help them out? :)


Here's a slightly altered one that doesn't require rescanning for the sake of the error message:

        Py_UCS4 c = 0, minc = strict ? 0x20 : 0x00;
        for (next = end; next < len; next++) {
            c = PyUnicode_READ(kind, buf, next);
            if (c == '"' || c == '\\' || c < minc) {
                break;
            }
        }
        if (c < minc) {
            raise_errmsg("Invalid control character at", pystr, next);
            goto bail;
        }
History
Date User Action Args
2019-07-30 15:43:52steve.dowersetrecipients: + steve.dower, rhettinger, ncoghlan, christian.heimes, ezio.melotti, methane, serhiy.storchaka, mpaolini, pablogsal, miss-islington
2019-07-30 15:43:52steve.dowersetmessageid: <1564501432.5.0.858745115243.issue37587@roundup.psfhosted.org>
2019-07-30 15:43:52steve.dowerlinkissue37587 messages
2019-07-30 15:43:52steve.dowercreate