Message348536
> The root of the error is that struct.pack_into starts by memsetting the underlying memory area with NULL bytes before filling the data with memcpy.
I've had a fix spinning for about a day now, it introduced a `multiprocessing.Lock` and it was simply wrapped around any struct packing and unpacking calls.
I've been reluctant to submit anything due to a suspicious resource warning I kept seeing about leaked shared_memory objects appearing spuriously and I wanted to rule out the possibility that other tests were causing a side effect.
Also I wanted to hear an expert from the noisy list share their thoughts.
> I'm not sure this should be done internally
I agree, even with my patch not reproducing the issue I didn't like placing a lock around various components in the class.
> +1 For a documentation addition.
If there are no objections, I'll submit a PR with a doc update :)
@Pierre mind if I cc' you for a review? |
|
Date |
User |
Action |
Args |
2019-07-27 01:27:06 | mental | set | recipients:
+ mental, pitrou, davin, bjs, pierreglaser |
2019-07-27 01:27:06 | mental | set | messageid: <1564190826.05.0.744485027201.issue37652@roundup.psfhosted.org> |
2019-07-27 01:27:06 | mental | link | issue37652 messages |
2019-07-27 01:27:05 | mental | create | |
|