Author vstinner
Recipients pablogsal, terry.reedy, vstinner
Date 2019-07-16.15:53:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1563292416.91.0.30477417171.issue37605@roundup.psfhosted.org>
In-reply-to
Content
> On Travis, 'Documentation tests' passing is apparently required.  Line 23 of nntplib.rst is ">>> s = NNTP('news.gmane.org')"  I use gmane and occasional failures to respond are routine.  Being able to merge should not depend on this external site.

Python test suite uses many external services:
https://pythondev.readthedocs.io/infra.html#services-used-by-unit-tests

You should all be skipped if the "network" resource is not used, which is the default.

Many tests were modified to catch network failures and ignore the test in this case. test_nntplib is known to be very fragile: it doesn't handle network issues.

I would suggest to remove functional tests which depend on external servers, since these tests fail often and nobody seems to care of test_nntplib.
History
Date User Action Args
2019-07-16 15:53:36vstinnersetrecipients: + vstinner, terry.reedy, pablogsal
2019-07-16 15:53:36vstinnersetmessageid: <1563292416.91.0.30477417171.issue37605@roundup.psfhosted.org>
2019-07-16 15:53:36vstinnerlinkissue37605 messages
2019-07-16 15:53:36vstinnercreate