Message346267
> Yep, just make sure the tests still pass before and after the change. :)
Sounds good, the first thing I had done before proposing the change was testing it in an IDE and using some logging to ensure that random.choose and random.choice were providing the same functionality. So hopefully the PR tests will pass as well.
> Separate are easier to review.
Alright, I'll do each of the file moves in individual PRs and then a separate one for changing random.choice to random.choose.
Thanks! |
|
Date |
User |
Action |
Args |
2019-06-22 02:37:49 | aeros | set | recipients:
+ aeros, brett.cannon, Arfrever, eric.snow, gforcada |
2019-06-22 02:37:49 | aeros | set | messageid: <1561171069.16.0.979090654227.issue19696@roundup.psfhosted.org> |
2019-06-22 02:37:49 | aeros | link | issue19696 messages |
2019-06-22 02:37:48 | aeros | create | |
|