This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author brett.cannon
Recipients Arfrever, aeros, brett.cannon, eric.snow, gforcada
Date 2019-06-21.17:03:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1561136589.49.0.80808348722.issue19696@roundup.psfhosted.org>
In-reply-to
Content
> Would it be appropriate to change the "choose" method to "choice"? 

Yep, just make sure the tests still pass before and after the change. :)

> should the name of "test_pkgimport" instead be "test_pkg_import"?

Since things are moving it's fine to rename the file.

> would it be best to perform all of these changes within separate pull requests, or are they minor enough to be combined into one?

Separate are easier to review.
History
Date User Action Args
2019-06-21 17:03:09brett.cannonsetrecipients: + brett.cannon, Arfrever, eric.snow, gforcada, aeros
2019-06-21 17:03:09brett.cannonsetmessageid: <1561136589.49.0.80808348722.issue19696@roundup.psfhosted.org>
2019-06-21 17:03:09brett.cannonlinkissue19696 messages
2019-06-21 17:03:09brett.cannoncreate