Message346235
> Would it be appropriate to change the "choose" method to "choice"?
Yep, just make sure the tests still pass before and after the change. :)
> should the name of "test_pkgimport" instead be "test_pkg_import"?
Since things are moving it's fine to rename the file.
> would it be best to perform all of these changes within separate pull requests, or are they minor enough to be combined into one?
Separate are easier to review. |
|
Date |
User |
Action |
Args |
2019-06-21 17:03:09 | brett.cannon | set | recipients:
+ brett.cannon, Arfrever, eric.snow, gforcada, aeros |
2019-06-21 17:03:09 | brett.cannon | set | messageid: <1561136589.49.0.80808348722.issue19696@roundup.psfhosted.org> |
2019-06-21 17:03:09 | brett.cannon | link | issue19696 messages |
2019-06-21 17:03:09 | brett.cannon | create | |
|