Author MorganRamsay
Recipients Jim.Jewett, MorganRamsay, NewerCookie, Sean Goodwin, amaury.forgeotdarc, apolkosnik, berker.peksag, chuck, francismb, georg.brandl, gregory.p.smith, ncoghlan, ronaldoussoren, serhiy.storchaka, terry.reedy
Date 2019-06-18.16:41:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1560876071.97.0.937186607706.issue6839@roundup.psfhosted.org>
In-reply-to
Content
The encoding test in ZipFile.open() is highly opinionated and has no purpose beyond itself. Testing for encoding issues should be done outside this library in the user's own code.

Using the 3.7.2 version of ZipFile, this is my proposal:

https://gist.github.com/MorganRamsay/696e89450e0f172c16ac8dfc016eb79f/revisions?diff=unified

Currently, I'm subclassing ZipFile with this patch and I've had no issues with extracting thousands of different ZIP files on Windows. I can't attest to this solution's applicability on other platforms.
History
Date User Action Args
2019-06-18 16:41:12MorganRamsaysetrecipients: + MorganRamsay, georg.brandl, terry.reedy, gregory.p.smith, ronaldoussoren, amaury.forgeotdarc, ncoghlan, NewerCookie, chuck, francismb, berker.peksag, Jim.Jewett, serhiy.storchaka, apolkosnik, Sean Goodwin
2019-06-18 16:41:11MorganRamsaysetmessageid: <1560876071.97.0.937186607706.issue6839@roundup.psfhosted.org>
2019-06-18 16:41:11MorganRamsaylinkissue6839 messages
2019-06-18 16:41:11MorganRamsaycreate