Author vstinner
Recipients Alex.Willmer, christian.heimes, pitrou, vstinner
Date 2019-06-12.14:02:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1560348138.08.0.359770862259.issue37210@roundup.psfhosted.org>
In-reply-to
Content
FYI pyperformance is affected by this issue:

vstinner@apu$ env/bin/python ~/prog/python/pyperformance/pyperformance/benchmarks/bm_pickle.py unpickle --pure-python -v -p3  
Traceback (most recent call last):
  File "/home/vstinner/prog/python/pyperformance/pyperformance/benchmarks/bm_pickle.py", line 287, in <module>
    import pickle
  File "/home/vstinner/prog/python/master/Lib/pickle.py", line 39, in <module>
    from _pickle import PickleBuffer
ModuleNotFoundError: import of _pickle halted; None in sys.modules

It is no longer possible to benchmark the pure Python implement of pickle.

--pure-python uses this code path:

def is_module_accelerated(module):
    return getattr(pickle.Pickler, '__module__', '<jython>') == 'pickle'

(...)

        if six.PY3:
            sys.modules['_pickle'] = None
        import pickle
        if not is_module_accelerated(pickle):
            raise RuntimeError("Unexpected C accelerators for pickle")

Should I remove the benchmark?
History
Date User Action Args
2019-06-12 14:02:18vstinnersetrecipients: + vstinner, pitrou, christian.heimes, Alex.Willmer
2019-06-12 14:02:18vstinnersetmessageid: <1560348138.08.0.359770862259.issue37210@roundup.psfhosted.org>
2019-06-12 14:02:18vstinnerlinkissue37210 messages
2019-06-12 14:02:17vstinnercreate