Message344813
Awesome work Victor! Thanks! I'll give it a try. One thing I see mising though (if I understand well) is the allocation of three fd_sets (I posted a comment on github regarding that).
Those fd_sets are currently allocated on stack and the array they contain is determined currently by FD_SETSIZE.
We'll basically need a similar structure that we can allocate dynamically, and cast it to fd_set when passing it to the select call.
I can go ahead and try implement the feedback and test it together with the changes in Victor's PR. |
|
Date |
User |
Action |
Args |
2019-06-06 13:09:35 | andzn | set | recipients:
+ andzn, paul.moore, pitrou, vstinner, tim.golden, asvetlov, zach.ware, desbma, eryksun, steve.dower, David Hirschfeld |
2019-06-06 13:09:35 | andzn | set | messageid: <1559826575.02.0.817418125101.issue28708@roundup.psfhosted.org> |
2019-06-06 13:09:35 | andzn | link | issue28708 messages |
2019-06-06 13:09:34 | andzn | create | |
|