Author petr.viktorin
Recipients Mark.Shannon, benjamin.peterson, jdemeyer, pablogsal, petr.viktorin
Date 2019-05-31.14:08:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1559311686.38.0.138561601848.issue36974@roundup.psfhosted.org>
In-reply-to
Content
I found an issue in PEP 590:

When inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call does not work for it.
Possible solutions come to mind:
- Inherit tp_vectorcall_offset more normally but handle setting __call__ specially
- Inherit tp_vectorcall_offset (but not _Py_TPFLAGS_HAVE_VECTORCALL) more normally, and make PyVectorcall_Call ignore _Py_TPFLAGS_HAVE_VECTORCALL

I'll send a PR for the latter.
History
Date User Action Args
2019-05-31 14:08:06petr.viktorinsetrecipients: + petr.viktorin, benjamin.peterson, Mark.Shannon, jdemeyer, pablogsal
2019-05-31 14:08:06petr.viktorinsetmessageid: <1559311686.38.0.138561601848.issue36974@roundup.psfhosted.org>
2019-05-31 14:08:06petr.viktorinlinkissue36974 messages
2019-05-31 14:08:06petr.viktorincreate