This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author taleinat
Recipients Michael.Felt, steve.dower, taleinat, vstinner
Date 2019-05-29.10:29:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1559125765.14.0.630593391034.issue36624@roundup.psfhosted.org>
In-reply-to
Content
There a cleanly rebased PR up at GH-13648.

I'd like to get opinions from additional people about this now that the PR is ready. Steve? Victor?


Some discussion which happened in PR comments:

Andrew Svetlov approved the changes for the asyncio tests.

Stefan Krah asked to revert the changes in test_decimal, saying "I don't quite like this change.". Michael Felt argued "imho - this adds clarity to the whole", to which Stefan replied: "I don't think so: Now I have to wonder which of the different idioms hides behind MS_WINDOWS. And in other project's setup.py files I still need sys.platform, so now there's even one additional way to accomplish the same thing."

Michael followed up with additional arguments in favor of this change, which are rather verbose, but can be summed up as saying that this adds clarity and uniformity throughout the tests.
History
Date User Action Args
2019-05-29 10:29:25taleinatsetrecipients: + taleinat, vstinner, steve.dower, Michael.Felt
2019-05-29 10:29:25taleinatsetmessageid: <1559125765.14.0.630593391034.issue36624@roundup.psfhosted.org>
2019-05-29 10:29:25taleinatlinkissue36624 messages
2019-05-29 10:29:24taleinatcreate