Message343847
> I think it would be best to replace the two calls with
> PyErr_SetFromWindowsErr(0) (for now).
For now it can at least be implemented inline. For example:
if (handle == NULL) {
PyObject *temp = name ? PyUnicode_FromWideChar(name, -1) : NULL;
PyErr_SetExcFromWindowsErrWithFilenameObjects(PyExc_OSError,
0, temp, NULL);
Py_XDECREF(temp);
handle = INVALID_HANDLE_VALUE;
}
I think undeprecating the two PyErr_ functions with a modified signature in 3.8 is okay since they were never in the documented API, never in the stable (limited) API, and Py_UNICODE has been a typedef for wchar_t since 3.3. |
|
Date |
User |
Action |
Args |
2019-05-29 01:17:01 | eryksun | set | recipients:
+ eryksun, vstinner, serhiy.storchaka, davin, ZackerySpytz |
2019-05-29 01:17:01 | eryksun | set | messageid: <1559092621.05.0.324244503824.issue36935@roundup.psfhosted.org> |
2019-05-29 01:17:01 | eryksun | link | issue36935 messages |
2019-05-29 01:17:00 | eryksun | create | |
|