Message343735
Making `source_to_code` a staticmethod on the `InspectLoader` abc but not in the `importlib.machinery` implementation causes awkwardness for anyone trying to inherit `SourceFileLoader` and override `source_to_code` in typechecked code, since typeshed assumes that `SourceFileLoader` actually implements the `importlib.abc.FileLoader` interface.
Given the ABC registration, it seems that `importlib.machinery.SourceFileLoader` should in fact implement the `importlib.abc.FileLoader` interface.
Should we make `SourceFileLoader.source_to_code` a staticmethod also? If so, I can file a separate bug for that. |
|
Date |
User |
Action |
Args |
2019-05-28 06:08:46 | carljm | set | recipients:
+ carljm, brett.cannon, python-dev, eric.snow |
2019-05-28 06:08:46 | carljm | set | messageid: <1559023726.3.0.713513349297.issue21156@roundup.psfhosted.org> |
2019-05-28 06:08:46 | carljm | link | issue21156 messages |
2019-05-28 06:08:46 | carljm | create | |
|