➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author remi.lapeyre
Recipients blueyed, remi.lapeyre
Date 2019-05-24.15:10:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1558710612.63.0.89224240138.issue37022@roundup.psfhosted.org>
In-reply-to
Content 
This part of the code is already used in three places and your patch would add two occurrences of of it, I think it would be great to put the part that print the exception in a private method, to avoid duplicating it all over the place.

Doing this seems small enough to me that I think it could be done in the same PR to avoid the overhead of having two separates PRs.
History
Date User Action Args
2019-05-24 15:10:12remi.lapeyresetrecipients: + remi.lapeyre, blueyed
2019-05-24 15:10:12remi.lapeyresetmessageid: <1558710612.63.0.89224240138.issue37022@roundup.psfhosted.org>
2019-05-24 15:10:12remi.lapeyrelinkissue37022 messages
2019-05-24 15:10:12remi.lapeyrecreate