Author serhiy.storchaka
Recipients Anthony Sottile, mbussonn, serhiy.storchaka
Date 2019-05-15.19:34:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1557948887.74.0.217548727938.issue36917@roundup.psfhosted.org>
In-reply-to
Content
You can not use the same implementation of the visitor for Num, Str, NameConstant and Ellipsis, because all these classes use different attribute for saving the value (Ellipsis does not have it at all). For the same reasons you can not just pass the argument of visit_Constant() to visit_Str() -- they have different types.

No need to call generic_visit() from visit_Constant() -- Constant nodes should not contain AST nodes.
History
Date User Action Args
2019-05-15 19:34:47serhiy.storchakasetrecipients: + serhiy.storchaka, mbussonn, Anthony Sottile
2019-05-15 19:34:47serhiy.storchakasetmessageid: <1557948887.74.0.217548727938.issue36917@roundup.psfhosted.org>
2019-05-15 19:34:47serhiy.storchakalinkissue36917 messages
2019-05-15 19:34:47serhiy.storchakacreate