This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mbussonn
Recipients Anthony Sottile, mbussonn, serhiy.storchaka
Date 2019-05-14.18:41:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
> There would still be a breakage for that if someone was defining py36+ `visit_Constant` (which would clobber the `ast.NodeVisitor.visit_Constant` if we were to add it)

Ok, it would still break in some cases, but that would still be a net improvement for codebase that do not override visit_Constant; right ? 

We could also push the patch further if we really want and call explicitly NodeVisitor.visit_Constant before the overridden method in NodeVisitor.visit.

Not advocating for the second part, but minimal breakage and code repetition in libraries when we can.
Date User Action Args
2019-05-14 18:41:33mbussonnsetrecipients: + mbussonn, serhiy.storchaka, Anthony Sottile
2019-05-14 18:41:33mbussonnsetmessageid: <>
2019-05-14 18:41:33mbussonnlinkissue36917 messages
2019-05-14 18:41:32mbussonncreate