Message342501
> There would still be a breakage for that if someone was defining py36+ `visit_Constant` (which would clobber the `ast.NodeVisitor.visit_Constant` if we were to add it)
Ok, it would still break in some cases, but that would still be a net improvement for codebase that do not override visit_Constant; right ?
We could also push the patch further if we really want and call explicitly NodeVisitor.visit_Constant before the overridden method in NodeVisitor.visit.
Not advocating for the second part, but minimal breakage and code repetition in libraries when we can. |
|
Date |
User |
Action |
Args |
2019-05-14 18:41:33 | mbussonn | set | recipients:
+ mbussonn, serhiy.storchaka, Anthony Sottile |
2019-05-14 18:41:33 | mbussonn | set | messageid: <1557859293.01.0.629738165624.issue36917@roundup.psfhosted.org> |
2019-05-14 18:41:33 | mbussonn | link | issue36917 messages |
2019-05-14 18:41:32 | mbussonn | create | |
|