Author giampaolo.rodola
Recipients Bart Oldeman, Gerrit.Holl, Maxime Boissonneault, giampaolo.rodola, obilaniu, r.david.murray, tarek
Date 2019-05-10.03:20:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1557458402.21.0.915825106263.issue24538@roundup.psfhosted.org>
In-reply-to
Content
Patch LGTM. I'd like to point out one thing for posterity. Current shutil code catches EPERM but not EACCES. While reviewing the patch I wondered whether simply catching (and ignoring) both error codes instead, but it turns out they are supposed to have 2 different meanings:
https://stackoverflow.com/a/35879961/376587
Especially after _copyxattr is moved before chmod() EACCES (permission denied) should propagate instead of being silenced, and EPERM should be left in place because in this case EPERM acts more like an ENOTSUP (operation not supported) than EACCES (permission denied) and as such should rightly be ignored.
History
Date User Action Args
2019-05-10 03:20:02giampaolo.rodolasetrecipients: + giampaolo.rodola, tarek, r.david.murray, Gerrit.Holl, Bart Oldeman, Maxime Boissonneault, obilaniu
2019-05-10 03:20:02giampaolo.rodolasetmessageid: <1557458402.21.0.915825106263.issue24538@roundup.psfhosted.org>
2019-05-10 03:20:02giampaolo.rodolalinkissue24538 messages
2019-05-10 03:20:02giampaolo.rodolacreate