Author hans-meine
Recipients Albert.Zeyer, Gabriel Devenyi, cdyson37, desbma, giampaolo.rodola, hans-meine, jhamrick, minrk, r.david.murray
Date 2019-05-08.07:49:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1557301779.66.0.52122746529.issue24564@roundup.psfhosted.org>
In-reply-to
Content
I completely agree with msg322848, both with the suggested fix and with its rationale.  A future API improvement could be to have a "strict" mode where errors copying xattr are not silently ignored anymore (if there are src xattr, but they cannot be written, or if src xattr cannot be read, for instance), but the current functionality seems to be "copy xattr if possible", and that should be fixed accordingly.

I also opened #36850 arguing that in any case, EINVAL should be ignored when *reading* extended attributes, acknowledging that people might have more problems with ignoring errors on *writing* them when they were present on the source.  However, as stated above, I personally vote for the fix suggested in msg322848.
History
Date User Action Args
2019-05-08 07:49:39hans-meinesetrecipients: + hans-meine, giampaolo.rodola, r.david.murray, Albert.Zeyer, desbma, minrk, jhamrick, Gabriel Devenyi, cdyson37
2019-05-08 07:49:39hans-meinesetmessageid: <1557301779.66.0.52122746529.issue24564@roundup.psfhosted.org>
2019-05-08 07:49:39hans-meinelinkissue24564 messages
2019-05-08 07:49:39hans-meinecreate