Message 340295 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	chris.jerdonek, eric.araujo, ezio.melotti, gregory.p.smith, miss-islington, rbcollins, vstinner, xdegaye
Date	2019-04-15.16:36:06
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1555346166.68.0.39666125436.issue16079@roundup.psfhosted.org>
In-reply-to

Content
Agreed, making duplicate method definitions a CI failure is the desired end state once our test suite is cleaned up and it doesn't have false positives. FYI - pylint also implements this check quite reliably as function-redefined via its pylint.checkers.base.BasicErrorChecker._check_redefinition() method. https://github.com/PyCQA/pylint/blob/2.2/pylint/checkers/base.py#L843

Agreed, making duplicate method definitions a CI failure is the desired end state once our test suite is cleaned up and it doesn't have false positives.

FYI - pylint also implements this check quite reliably as function-redefined via its pylint.checkers.base.BasicErrorChecker._check_redefinition() method.

https://github.com/PyCQA/pylint/blob/2.2/pylint/checkers/base.py#L843

History
Date	User	Action	Args
2019-04-15 16:36:06	gregory.p.smith	set	recipients: + gregory.p.smith, vstinner, rbcollins, ezio.melotti, eric.araujo, chris.jerdonek, xdegaye, miss-islington
2019-04-15 16:36:06	gregory.p.smith	set	messageid: <1555346166.68.0.39666125436.issue16079@roundup.psfhosted.org>
2019-04-15 16:36:06	gregory.p.smith	link	issue16079 messages
2019-04-15 16:36:06	gregory.p.smith	create