This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Michael.Felt
Recipients Michael.Felt
Date 2019-04-13.12:25:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1555158343.77.0.950141438455.issue36624@roundup.psfhosted.org>
In-reply-to
Content
Back in 2012 (issue12326 and issue12795), and just recently (issue36588) sys.platform has been modified (and documented) to not return the platform version.

Additionally, the recommendation is to use the form sys.platform.startswith(<platform>) - to continue to be backwards compatible.

IMHO - looking forward - Python3.8 and later - we should not be using the recommendation for 'backwards-compatibility' in our code (so this PR will not be considered for back-porting) - in our stdlib, tests, and - should it occur - in "core" code. We should be testing for equality.

Further, imho, the change should not be sys.platform == <platform> but should be platform.system() == <Platform>, or platform.system() in ('AIX', 'Darwin', 'Linux') -- and adjust the list so that the most frequently used platform is tested first (e.g., performance-wise ('Linux', 'Darwin', 'AIX') would better reflect platform importance.

OR - should the change just continue to use sys.platform - even though this is a build-time value, not a run-time value.

I propose to do this in separate PR - one for each platform of AIX, Darwin and Linux.

(I would also add Windows, but that would be to replace the equivalence of sys.platform == 'win32' with platform.system() == 'Windows', and perhaps, os.name == 'nt' with platform.system() == 'Windows'. Reaction from other platforms dependent on os.name == 'nt' (cygwin?) would be helpful.)

Finally, while I do not want to rush this - I would like to try and target getting this complete in time for Python3.8
History
Date User Action Args
2019-04-13 12:25:43Michael.Feltsetrecipients: + Michael.Felt
2019-04-13 12:25:43Michael.Feltsetmessageid: <1555158343.77.0.950141438455.issue36624@roundup.psfhosted.org>
2019-04-13 12:25:43Michael.Feltlinkissue36624 messages
2019-04-13 12:25:43Michael.Feltcreate