Message338210
@carlbordum, thank you for the PR, but the original PR already addresses the issues. In a code review message on that PR (https://github.com/python/cpython/pull/1034#pullrequestreview-32006381), @rhettinger commented on the removal of the print statement in the method call, which was addressed by the creator of that PR. PR1034 was just waiting for final review and approval.
The difference between this and the print in the classmethod example is that having to two prints in this example resulted in output of:
>>> E.f(3)
3
>>> print(E.f(3))
3
None
whereas the classmethod example doesn't have the issue of printing `None`.
I don't think the second PR is necessary. |
|
Date |
User |
Action |
Args |
2019-03-18 12:23:34 | cheryl.sabella | set | recipients:
+ cheryl.sabella, rhettinger, docs@python, bjonnh, carlbordum |
2019-03-18 12:23:34 | cheryl.sabella | set | messageid: <1552911814.56.0.171917061234.issue23984@roundup.psfhosted.org> |
2019-03-18 12:23:34 | cheryl.sabella | link | issue23984 messages |
2019-03-18 12:23:34 | cheryl.sabella | create | |
|