This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author cheryl.sabella
Recipients brett.cannon, cheryl.sabella, steve.dower, vinay.sajip, vstinner
Date 2019-03-12.22:41:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1552430479.0.0.76744764713.issue35661@roundup.psfhosted.org>
In-reply-to
Content
Steve, thanks for the suggestions.  

Looking at the other tests, `test_prompt` was the only one (prior to the original change) that didn't create a venv, so maybe actually creating the venv instead of just instantiating the class were testing that everything worked together?  For example, see `test_isolation` and `test_symlinking`.  

I've added the code to explicitly remove the directory and I also slightly reorganized the create.  Not all the tests use the `run_with_capture`, but at the same time, none of the ones that use it do anything with the output, so I thought it wouldn't hurt to add it.

I tried to submit the tests just to the buildbots based on the devguide, but they were failing for other reasons, so I made the PR.  I don't think we'll know if this fixes the bots until the PR is merged, but if one of you could take a look and approve it, I'd appreciate it.  And then I'll keep my fingers crossed.   :-)
History
Date User Action Args
2019-03-12 22:41:19cheryl.sabellasetrecipients: + cheryl.sabella, brett.cannon, vinay.sajip, vstinner, steve.dower
2019-03-12 22:41:18cheryl.sabellasetmessageid: <1552430479.0.0.76744764713.issue35661@roundup.psfhosted.org>
2019-03-12 22:41:18cheryl.sabellalinkissue35661 messages
2019-03-12 22:41:18cheryl.sabellacreate