Author eric.snow
Recipients Johan Dahlin, emilyemorehouse, eric.snow, nascheme, ncoghlan, pmpp, serhiy.storchaka, vstinner, yselivanov
Date 2019-02-26.02:29:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1551148146.82.0.295863276171.issue33608@roundup.psfhosted.org>
In-reply-to
Content
At least, it *might* be a performance regression.  Here are the two commits I tried:

after:  ef4ac967e2f3a9a18330cc6abe14adb4bc3d0465 (PR #11617, from this issue)
before:  463572c8beb59fd9d6850440af48a5c5f4c0c0c9 (the one right before)

After building each (a normal build, not debug), I ran the micro-benchmark Raymond referred to ("./python Tools/scripts/var_access_benchmark.py") multiple times.  There was enough variability between runs from the same commit that I'm uncertain at this point if there really is any performance regression.  For the most part the results between the two commits are really close.  Also, the results from the "after" commit fall within the variability I've seen between runs of the "before" commit.

I'm going to try with the "performance" suite (https://github.com/python/performance) to see if it shows any regression.
History
Date User Action Args
2019-02-26 02:29:06eric.snowsetrecipients: + eric.snow, nascheme, ncoghlan, vstinner, pmpp, serhiy.storchaka, yselivanov, emilyemorehouse, Johan Dahlin
2019-02-26 02:29:06eric.snowsetmessageid: <1551148146.82.0.295863276171.issue33608@roundup.psfhosted.org>
2019-02-26 02:29:06eric.snowlinkissue33608 messages
2019-02-26 02:29:06eric.snowcreate