Message336415
From Terry's comment on PR11472 for issue 35689:
> I don't like the use of class variables to initialize volatile instance state variables. I think it confuses the code a bit. Better, I think, to put them in an `init_state` method called from `__init__`. (I am not sure if method could be used in tests.) Since the tests do not access the class vars directly on the class, they should not be affected. I am leaving this minor refactoring for another issue after merging the tests. Then we can modify the class docstring. |
|
Date |
User |
Action |
Args |
2019-02-23 22:53:19 | cheryl.sabella | set | recipients:
+ cheryl.sabella, terry.reedy |
2019-02-23 22:53:18 | cheryl.sabella | set | messageid: <1550962398.99.0.0484672984397.issue36096@roundup.psfhosted.org> |
2019-02-23 22:53:18 | cheryl.sabella | link | issue36096 messages |
2019-02-23 22:53:18 | cheryl.sabella | create | |
|