Author ethan.furman
Recipients Maxpxt, barry, bdbaraban, cheryl.sabella, corona10, eli.bendersky, ethan.furman, matrixise, remi.lapeyre
Date 2019-02-21.21:14:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1550783651.47.0.230704781484.issue35899@roundup.psfhosted.org>
In-reply-to
Content
The changes to `_is_sunder` and `_is_dunder` look good, but there is a problem with the underlying assumptions of what Enum should be doing:

- nameless members are not to be allowed
- non-alphanumeric characters are not supported

In other words, while `_is_sunder` should not fail, neither should an empty string be allowed as a member name.  This can be checked at line 154 (just add '' to the set) -- then double check that the error raised is a ValueError and not an IndexError.

For the strange character portion, use some non-latin numbers and letters to make sure they work, but don't check for symbols such as exclamation points -- while they might work, we are not supporting such things, and having a test that checks to make sure they work suggests that we do support it.
History
Date User Action Args
2019-02-21 21:14:11ethan.furmansetrecipients: + ethan.furman, barry, eli.bendersky, matrixise, cheryl.sabella, corona10, remi.lapeyre, bdbaraban, Maxpxt
2019-02-21 21:14:11ethan.furmansetmessageid: <1550783651.47.0.230704781484.issue35899@roundup.psfhosted.org>
2019-02-21 21:14:11ethan.furmanlinkissue35899 messages
2019-02-21 21:14:11ethan.furmancreate