Message336229
> Once I had wrote a similar patch that adds PyTuple_FromArray, but never published it because I did not found enough use cases for this function. Although I considered using it only for removing some code duplication, but Sergey shown that it can be used for small performance boost in some special cases. I am still not sure, but this argument makes this change a tiny bit more attractive. Leave this on Raymond.
The micro-benchmark results are not really impressive. I still like PR 11954 because it removes code (simply loops). _PyTuple_FromArray() has a well defined API and is safe (I'm saying that because PR 11927 adds an "unsafe" function). As soon as it's private, I'm fine with it.
I'm more attracted by the code simplification than performance boost here. |
|
Date |
User |
Action |
Args |
2019-02-21 15:20:55 | vstinner | set | recipients:
+ vstinner, rhettinger, serhiy.storchaka, sir-sigurd |
2019-02-21 15:20:55 | vstinner | set | messageid: <1550762455.69.0.957807423246.issue36030@roundup.psfhosted.org> |
2019-02-21 15:20:55 | vstinner | link | issue36030 messages |
2019-02-21 15:20:55 | vstinner | create | |
|