Author giampaolo.rodola
Recipients abrezovsky, christian.heimes, eryksun, giampaolo.rodola, jgosmann, mhils, paul.moore, steve.dower, tim.golden, zach.ware
Date 2019-02-19.11:44:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1550576649.83.0.594739425385.issue29515@roundup.psfhosted.org>
In-reply-to
Content
@eryksun I tried your patch (https://bugs.python.org/issue29515#msg287477) on Windows 10 and it looks good. It introduces the following new constants:

IPPROTO_IGMP
IPPROTO_GGP
IPPROTO_PUP
IPPROTO_IDP
IPPROTO_ND
IPPROTO_MAX
IPPROTO_HOPOPTS
IPPROTO_IPV4
IPPROTO_IPV6
IPPROTO_ROUTING
IPPROTO_FRAGMENT
IPPROTO_ESP
IPPROTO_AH
IPPROTO_ICMPV6
IPPROTO_NONE
IPPROTO_DSTOPTS
IPPROTO_EGP
IPPROTO_PIM
IPPROTO_SCTP

...plus these Windows-only ones for which I had to add an additional PyModule_AddIntMacro() call:

IPPROTO_ICLFXBM
IPPROTO_ST
IPPROTO_CBT
IPPROTO_IGP
IPPROTO_RDP
IPPROTO_PGM
IPPROTO_L2TP

Up 'till now only these ones were exposed:

IPPROTO_ICMP
IPPROTO_TCP
IPPROTO_UDP
IPPROTO_RAW

I think we can proceed with this. Care to provide a patch?
History
Date User Action Args
2019-02-19 11:44:09giampaolo.rodolasetrecipients: + giampaolo.rodola, paul.moore, christian.heimes, tim.golden, zach.ware, eryksun, steve.dower, jgosmann, mhils, abrezovsky
2019-02-19 11:44:09giampaolo.rodolasetmessageid: <1550576649.83.0.594739425385.issue29515@roundup.psfhosted.org>
2019-02-19 11:44:09giampaolo.rodolalinkissue29515 messages
2019-02-19 11:44:09giampaolo.rodolacreate