Author scoder
Recipients Yasser Alshalaan, nascheme, pablogsal, rhettinger, scoder, vstinner
Date 2019-02-17.14:36:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1550414175.14.0.562286002494.issue36012@roundup.psfhosted.org>
In-reply-to
Content
It turns out that "update_slot()" is always called, even when we are not updating a slot name (which is always a special dunder-name). The linear search for names in "update_slots()" is a huge waste of time here, and short-circuiting out of it when the name does not start with "_" cuts the overall update time by 50%. I pushed a PR.

Another improvement would be a sub-linear algorithm for searching the slot name, but that's a bigger change.
History
Date User Action Args
2019-02-17 14:36:15scodersetrecipients: + scoder, nascheme, rhettinger, vstinner, pablogsal, Yasser Alshalaan
2019-02-17 14:36:15scodersetmessageid: <1550414175.14.0.562286002494.issue36012@roundup.psfhosted.org>
2019-02-17 14:36:15scoderlinkissue36012 messages
2019-02-17 14:36:15scodercreate