Message 335523 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	matrixise
Recipients	eamanu, lidayan, matrixise
Date	2019-02-14.12:20:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1550146827.21.0.526339970748.issue35995@roundup.psfhosted.org>
In-reply-to

Content
@lidayan I have checked the code of your PR, and I think there is an issue with your code. 1. When you specify the secure flag to the SMTPHandler, it's because you will start the TLS connection if the SMTP server supports the STARTTLS. Firstly in plaintext mode and if STARTTLS is supported then we move to the TLS encryption. 2. If you use SSL + SMTP, it's not the same behavior because you support that your SMTP server will support a socket + ssl. For my part, I suggest you the creation of a SMTPSSLHandler and use the SMTP_SSL class.

@lidayan

I have checked the code of your PR, and I think there is an issue with your code.

1. When you specify the secure flag to the SMTPHandler, it's because you will start the TLS connection if the SMTP server supports the STARTTLS. Firstly in plaintext mode and if STARTTLS is supported then we move to the TLS encryption.

2. If you use SSL + SMTP, it's not the same behavior because you support that your SMTP server will support a socket + ssl.

For my part, I suggest you the creation of a SMTPSSLHandler and use the SMTP_SSL class.

History
Date	User	Action	Args
2019-02-14 12:20:27	matrixise	set	recipients: + matrixise, eamanu, lidayan
2019-02-14 12:20:27	matrixise	set	messageid: <1550146827.21.0.526339970748.issue35995@roundup.psfhosted.org>
2019-02-14 12:20:27	matrixise	link	issue35995 messages
2019-02-14 12:20:27	matrixise	create