Message335269
It's probably OK, but there's no "pure win" to be had here. There's generally more than one way to convert one string to another, and what "looks right" to humans depends a whole lot on context.
For example, consider these strings:
"private Thread currentThread;"
"private volatile Thread currentThread;"
"It's obvious" someone inserted "volatile" into the first string, and that's what ndiff's default says:
- private Thread currentThread;
+ private volatile Thread currentThread;
? +++++++++
However, pass `charjunk=None` instead, and ndiff claims someone inserted "e volatil" after the "t" in "private":
- private Thread currentThread;
+ private volatile Thread currentThread;
? +++++++++
Which is also a correct way, but - to human eyes - an insane way ;-) |
|
Date |
User |
Action |
Args |
2019-02-11 20:07:41 | tim.peters | set | recipients:
+ tim.peters, jaraco, chris.jerdonek, xtreak |
2019-02-11 20:07:41 | tim.peters | set | messageid: <1549915661.45.0.782148296356.issue35955@roundup.psfhosted.org> |
2019-02-11 20:07:41 | tim.peters | link | issue35955 messages |
2019-02-11 20:07:41 | tim.peters | create | |
|