Author xtreak
Recipients Adnan Umer, cheryl.sabella, cjw296, mariocj89, michael.foord, taleinat, terry.reedy, xtreak
Date 2019-02-10.07:33:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549784019.48.0.642473566671.issue35500@roundup.psfhosted.org>
In-reply-to
Content
I think "Actual" is more consistent with other error messages like assert_has_calls. I haven't seen usage of observed or received in error messages and hence my opinion on using expected and actual though they are not visually aligned. I don't have a strong opinion on this. I will leave it to the maintainer who wants to merge this change and I am fine as long as the calls are represented on separate lines which is a good improvement over current format.

>>> m.assert_has_calls(mock.call(1))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/mock.py", line 857, in assert_has_calls
    raise AssertionError(
AssertionError: Calls not found.
Expected: ['', (1,), {}]
Actual: [call(1), call(2)].
History
Date User Action Args
2019-02-10 07:33:41xtreaksetrecipients: + xtreak, terry.reedy, taleinat, cjw296, michael.foord, cheryl.sabella, mariocj89, Adnan Umer
2019-02-10 07:33:39xtreaksetmessageid: <1549784019.48.0.642473566671.issue35500@roundup.psfhosted.org>
2019-02-10 07:33:39xtreaklinkissue35500 messages
2019-02-10 07:33:39xtreakcreate