Message335096
I agree that more generally PyImport_GetModule() should be fixed. But it should be done carefully so as to not to lose the performance benefit of doing it. I think we should open a separate issue about that.
PS: one possibility is to reuse the optimization already done in PyImport_ImportModuleLevelObject():
/* Optimization: only call _bootstrap._lock_unlock_module() if
__spec__._initializing is true.
NOTE: because of this, initializing must be set *before*
stuffing the new module in sys.modules.
*/
spec = _PyObject_GetAttrId(mod, &PyId___spec__);
if (_PyModuleSpec_IsInitializing(spec)) {
PyObject *value = _PyObject_CallMethodIdObjArgs(interp->importlib,
&PyId__lock_unlock_module, abs_name,
NULL);
if (value == NULL) {
Py_DECREF(spec);
goto error;
}
Py_DECREF(value);
}
Py_XDECREF(spec); |
|
Date |
User |
Action |
Args |
2019-02-08 17:09:58 | pitrou | set | recipients:
+ pitrou, brett.cannon, ncoghlan, alexandre.vassalotti, eric.snow, tjb900 |
2019-02-08 17:09:57 | pitrou | set | messageid: <1549645797.37.0.905614206087.issue34572@roundup.psfhosted.org> |
2019-02-08 17:09:57 | pitrou | link | issue34572 messages |
2019-02-08 17:09:57 | pitrou | create | |
|