Author Isaac Boukris
Recipients Isaac Boukris, asvetlov, eamanu, giampaolo.rodola, josiahcarlson, stutzbach
Date 2019-02-06.22:56:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549493793.61.0.589898685708.issue35913@roundup.psfhosted.org>
In-reply-to
Content
> But I want to raise the flag again: why we are adding new functionality to the *deprecated* module? It violates our on deprecation policy, isn't it?

I'm biased but I see this as more of a small and subtle fix for the current logic that incorrectly treats this as a closed connection, rather than a new feature.
In addition, it could serve a documentation hint for people troubleshooting edge cases in their code (especially people who are not familiar with these semantics).

> Point with asyncore/chat is that every time you try to fix them you end up messing with the public API one way or another.

I'd agree about the first commit (avoid calling recv with size zero), which may change the behavior for a poorly written application that tries to read a chunk of zero bytes, but the second commit is straight forward and I can't see how it could break anything.
History
Date User Action Args
2019-02-06 22:56:35Isaac Boukrissetrecipients: + Isaac Boukris, josiahcarlson, giampaolo.rodola, stutzbach, asvetlov, eamanu
2019-02-06 22:56:33Isaac Boukrissetmessageid: <1549493793.61.0.589898685708.issue35913@roundup.psfhosted.org>
2019-02-06 22:56:33Isaac Boukrislinkissue35913 messages
2019-02-06 22:56:33Isaac Boukriscreate