Author giampaolo.rodola
Recipients Isaac Boukris, asvetlov, eamanu, giampaolo.rodola, josiahcarlson, stutzbach
Date 2019-02-06.21:27:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549488431.49.0.32987312443.issue35913@roundup.psfhosted.org>
In-reply-to
Content
I agree. The problem I have with this is that it introduces a new method (handle_eof), which ends up in the "new functionality" bucket (even though it's not backward incompatible per-se, as it defaults on calling handle_close() anyway, but still it is technically a new API). Point with asyncore/chat is that every time you try to fix them you end up messing with the public API one way or another.

I know from experience (pyftpdlib) that all asyncore/chat users already subclass/overwrite the base classes quite massively, so if they really want to rely on this new functionality they probably already have implemented it themselves.
History
Date User Action Args
2019-02-06 21:27:12giampaolo.rodolasetrecipients: + giampaolo.rodola, josiahcarlson, stutzbach, asvetlov, eamanu, Isaac Boukris
2019-02-06 21:27:11giampaolo.rodolasetmessageid: <1549488431.49.0.32987312443.issue35913@roundup.psfhosted.org>
2019-02-06 21:27:11giampaolo.rodolalinkissue35913 messages
2019-02-06 21:27:11giampaolo.rodolacreate