Author ronaldoussoren
Recipients brett.cannon, davin, eric.snow, lukasz.langa, pitrou, rhettinger, ronaldoussoren, terry.reedy, yselivanov
Date 2019-02-04.06:44:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549262675.77.0.60167907323.issue35813@roundup.psfhosted.org>
In-reply-to
Content
David, 

I don't agree with merging at this point.

The lack of documentation makes it hard to ask for more feedback and broader testing, because people won't know how to use the library and provide constructive feedback (that's why my review comments on GitHub are mostly nitpicking).

Furthermore, distributing this as a package on PyPI is much better way to solicit further testing and feedback, because then it can be used right now instead of having to wait for a release. Releasing on PyPI is feasible for this new functionality because it is a standalone library.

It would be better to revert this changeset until it is much closer to finished and there has been time for better code review.

BTW. My comment about copyright on the pull request was about the __copyright__ attribute of the C extension, that is rarely used in the stdlib and is IMHO something to avoid.
History
Date User Action Args
2019-02-04 06:44:37ronaldoussorensetrecipients: + ronaldoussoren, brett.cannon, rhettinger, terry.reedy, pitrou, lukasz.langa, eric.snow, yselivanov, davin
2019-02-04 06:44:35ronaldoussorensetmessageid: <1549262675.77.0.60167907323.issue35813@roundup.psfhosted.org>
2019-02-04 06:44:35ronaldoussorenlinkissue35813 messages
2019-02-04 06:44:35ronaldoussorencreate