Message334768
We certainly shouldn't be calling CloseHandle on a parameter like this anyway, so the change looks good to me.
However, I notice that we don't necessarily preserve GetLastError() throughout here, so perhaps we ought to consider changing the return value interpretation at some point? (e.g. CloseHandle() may change it, and so we lose the actual error) That can be a future task though. |
|
Date |
User |
Action |
Args |
2019-02-02 21:08:00 | steve.dower | set | recipients:
+ steve.dower, paul.moore, tim.golden, zach.ware, eryksun |
2019-02-02 21:07:58 | steve.dower | set | messageid: <1549141678.96.0.166095424472.issue29734@roundup.psfhosted.org> |
2019-02-02 21:07:58 | steve.dower | link | issue29734 messages |
2019-02-02 21:07:58 | steve.dower | create | |
|