This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nnja
Recipients barry, nnja
Date 2019-02-02.01:42:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549071736.85.0.965218389814.issue35887@roundup.psfhosted.org>
In-reply-to
Content
In the process of creating a fix for issue #35321, I noticed what I believe to be a documentation omission. 

In Lib/importlib/_bootstrap.py the top level comment states that:

# IMPORTANT: Whenever making changes to this module, be sure to run
# a top-level make in order to get the frozen version of the module
# updated.

From my testing, it appears that the header file will only be updated when running `make regen-importlib`

To repo:
- make a code change in Lib/importlib/_bootstrap_external.py
- run a top-level `make`
- see that Python/importlib.h does not change
- run `make regen-importlib`
- see that Python/importlib.h has now been updated

The documentation in Lib/importlib/_bootstrap_external.py does in fact mention this.

I propose amending the documentation to include the correct instructions.

If this is deemed necessary, I will write the patch over the weekend.
History
Date User Action Args
2019-02-02 01:42:18nnjasetrecipients: + nnja, barry
2019-02-02 01:42:16nnjasetmessageid: <1549071736.85.0.965218389814.issue35887@roundup.psfhosted.org>
2019-02-02 01:42:16nnjalinkissue35887 messages
2019-02-02 01:42:16nnjacreate