Message334486
> I'm also mildly concerned by how duplicative the code becomes post-patch.
I know, that's why I added that comment on GitHub.
> perhaps just implement _PyTime_ObjectToTime_t as a wrapper for _PyTime_ObjectToDenominator
Sure, but will that increase the chances of PR 11636 being accepted? Unless a core developer who is willing to merge that PR asks me that, I'd rather not add extra complications to that PR. (to be clear: I mean no offense, it's just that getting a CPython PR accepted is hard) |
|
Date |
User |
Action |
Args |
2019-01-28 18:15:00 | jdemeyer | set | recipients:
+ jdemeyer, ronaldoussoren, ncoghlan, vstinner, serhiy.storchaka, josh.r, remi.lapeyre, AVINASH MISHRA |
2019-01-28 18:14:58 | jdemeyer | set | messageid: <1548699298.48.0.641639584005.issue35707@roundup.psfhosted.org> |
2019-01-28 18:14:58 | jdemeyer | link | issue35707 messages |
2019-01-28 18:14:58 | jdemeyer | create | |
|