Author eryksun
Recipients eryksun, paul.moore, steve.dower, tim.golden, vinay.sajip, zach.ware
Date 2019-01-24.19:26:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1548357987.14.0.246110301265.issue35811@roundup.psfhosted.org>
In-reply-to
Content
> But if I understood what Steve said, only if path\to\python.exe is 
> a *relative* pathname?

I believe Steve is referring to behavior changes for applications that relied on a virtual environment's "Scripts" directory always being in the EXE and default DLL and generic search paths because it was the application directory (i.e. "%__APPDIR__%"), which I had discussed in a follow-up note. I suggested that this could be mitigated by having the new venv launchers also prepend their directory to PATH. It wouldn't help in all cases, but it's the best we can do. 

The issue with __PYVENV_LAUNCHER__ and the py.exe and entry-point launchers is unrelated to relative paths. Perhaps it will clarify the situation to show how this variable is actually used in PC/getpathp.c. It's a pretty simple change:

    /* The launcher may need to force the executable path to a
     * different environment, so override it here. */
    pyvenv_launcher = _wgetenv(L"__PYVENV_LAUNCHER__");
    if (pyvenv_launcher && pyvenv_launcher[0]) {
        wcscpy_s(program_full_path, MAXPATHLEN+1, pyvenv_launcher);
    } else if (!GetModuleFileNameW(NULL, program_full_path, MAXPATHLEN)) {
        /* GetModuleFileName should never fail when passed NULL */
        return _Py_INIT_ERR("Cannot determine program path");
}

https://github.com/python/cpython/blob/v3.7.2/PC/getpathp.c#L535
History
Date User Action Args
2019-01-24 19:26:29eryksunsetrecipients: + eryksun, paul.moore, vinay.sajip, tim.golden, zach.ware, steve.dower
2019-01-24 19:26:27eryksunsetmessageid: <1548357987.14.0.246110301265.issue35811@roundup.psfhosted.org>
2019-01-24 19:26:27eryksunlinkissue35811 messages
2019-01-24 19:26:26eryksuncreate