This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eamanu
Recipients Alexander Oblovatniy, azsorkin, berker.peksag, cjw296, dojutsu-user, eamanu, mariocj89, michael.foord, nekobon, r.david.murray, rbcollins, rhettinger, xtreak
Date 2019-01-20.15:03:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1547996599.82.0.583586102102.issue24928@roundup.psfhosted.org>
In-reply-to
Content
Hi Berker, 

Thanks for you response. 

I agree when you say that patch.dict is a simply operation, but I think that this test can be necessary, if for some reason the implementation of patch.dict (or its parts) decide change. 

> I think the relationship between dict and OrderedDict (including any other dict subclasses and dict-like objects) and anything related to insertion order should be tested either in test_dict or in test_ordered_dict.

I am not sure if this has to be tested on test_dict or test_oredered_dict, because we are not testing specifically dict-like objects.

This test, can be written on test_patch_dict and not create a new `test_patch_dict_with_orderdict`.
History
Date User Action Args
2019-01-20 15:03:20eamanusetrecipients: + eamanu, rhettinger, rbcollins, cjw296, r.david.murray, michael.foord, berker.peksag, nekobon, azsorkin, Alexander Oblovatniy, mariocj89, xtreak, dojutsu-user
2019-01-20 15:03:19eamanusetmessageid: <1547996599.82.0.583586102102.issue24928@roundup.psfhosted.org>
2019-01-20 15:03:19eamanulinkissue24928 messages
2019-01-20 15:03:19eamanucreate