Message 333573 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pablogsal
Recipients	ericvw, pablogsal, pitrou, tzickel, vstinner
Date	2019-01-13.22:04:00
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1547417040.6.0.578825429671.issue35378@roundup.psfhosted.org>
In-reply-to

Content
I have been playing with possible solutions for a while and the weak-reference solution seems not robust enough as there are too potential race conditions between the destruction of the weakreferences (the pool) and the handling code. I would advocate again for using a strong reference. The reasons are: * The rest of the stdlib is using this solution to link iterator objects and similar to their parents (lists, dicts, sets...etc all have strong references back to their parents). * This solution is backwards compatible with the current behaviour. * We have the new ResourceWarnigns to make clear that this behaviour is not supported.

I have been playing with possible solutions for a while and the weak-reference solution seems not robust enough as there are too potential race conditions between the destruction of the weakreferences (the pool) and the handling code.

I would advocate again for using a strong reference. The reasons are:

* The rest of the stdlib is using this solution to link iterator objects and similar to their parents (lists, dicts, sets...etc all have strong references back to their parents).

* This solution is backwards compatible with the current behaviour.

* We have the new ResourceWarnigns to make clear that this behaviour is not supported.

History
Date	User	Action	Args
2019-01-13 22:04:01	pablogsal	set	recipients: + pablogsal, pitrou, vstinner, ericvw, tzickel
2019-01-13 22:04:00	pablogsal	set	messageid: <1547417040.6.0.578825429671.issue35378@roundup.psfhosted.org>
2019-01-13 22:04:00	pablogsal	link	issue35378 messages
2019-01-13 22:04:00	pablogsal	create