Author remi.lapeyre
Recipients cjw296, mariocj89, michael.foord, remi.lapeyre, ron.rothman, xtreak
Date 2019-01-11.16:13:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1547223218.37.0.784586008664.issue31855@roundup.psfhosted.org>
In-reply-to
Content
The off-by-one error in a test added for an unrelated issue (#17467) makes me think @michael.foord just made a mistake in the test.

> mock_open docs mentions about using a customized mock for complex cases
I think it's more for complex things like fetching data using a callback for example, this seems like a normal use case for mock_open(). Even more so, leaving the behavior as it is now may lead someone to think there is a bug in its code.

I opened a new PR to fix this issue: https://github.com/python/cpython/pull/11521
History
Date User Action Args
2019-01-11 16:13:40remi.lapeyresetrecipients: + remi.lapeyre, cjw296, michael.foord, mariocj89, ron.rothman, xtreak
2019-01-11 16:13:38remi.lapeyresetmessageid: <1547223218.37.0.784586008664.issue31855@roundup.psfhosted.org>
2019-01-11 16:13:38remi.lapeyrelinkissue31855 messages
2019-01-11 16:13:38remi.lapeyrecreate