This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vajrasky
Recipients antonymayi, drpotato, jcea, lars.gustaebel, martin.panter, serhiy.storchaka, vajrasky, vstinner
Date 2019-01-06.08:57:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1546765052.24.0.684265039179.issue19974@roundup.psfhosted.org>
In-reply-to
Content
Martin Panter,

I have modernized the patch.

About your suggestion:
1. "import errno" -> Yes, this is unnecessary. I have removed it.
2. Use os.path.lexists instead of os.path.islink for broken symlink -> The thing is os.path.islink returns True also for broken symlink. I could not find a case where these methods return different result.
History
Date User Action Args
2019-01-06 08:57:33vajraskysetrecipients: + vajrasky, jcea, lars.gustaebel, vstinner, martin.panter, serhiy.storchaka, antonymayi, drpotato
2019-01-06 08:57:32vajraskysetmessageid: <1546765052.24.0.684265039179.issue19974@roundup.psfhosted.org>
2019-01-06 08:57:32vajraskylinkissue19974 messages
2019-01-06 08:57:32vajraskycreate